Im a lifelong Cowboys fan too and I like the signing. He's arguably the best receiver in the game and his mere presence on the field will lift double teams from Terry Glenn and open the running game simply because you most likely will require two defenders to cover him.
As for the personality issues, Bill Parcells is a future Hall of Fame coach and maybe, just maybe, he can whip him into shape.