Jump to content
The Community Blog (An Invitation)

Noqn

Members
 View Profile  See their activity

  • Posts

    462

  • Joined

  • Last visited

  • Days Won

    2

 Content Type 

Posts posted by Noqn

    Apotheosis - Mod Editor for Deadfire

    in Pillars of Eternity II: Deadfire: Modding (Spoiler Warning!)

    Posted

    New release! I've implemented automatic updates! 🥳 (You still have to install *this* version manually though)

    eQelmuX.png

    I've also added a popup selector for most of the *.prefab fields. You'll get to choose from among what's available in the corresponding "PillarsOfEternityII_Data/assetbundles/*.unity3d" files.

    This will make it a lot easier to find values for character and effect prefabs, among others.

    xW6gnWc.png

    Also started exporting conversations.manifest and fixed some other stuff mentioned here:

    2023-01-19

    • Auto Updates! When a new release is available, a dialog will give the user the opportunity to download it.
    • Added a "prefab path" selector popup.
    • conversations.manifest files will now be exported.
    • Fixed an issue which caused GameDataObjects to be created with DebugName set to null.
    • SpeakerComponent.ChatterFile will now correctly default to an empty ID string.
    • Improved generation time of Conversation & Quest diagrams.
    • StringTable queries now search GameData/Conversation/Quest tables asynchronously.

     

    • Like 4

    Apotheosis - Mod Editor for Deadfire

    in Pillars of Eternity II: Deadfire: Modding (Spoiler Warning!)

    Posted

    On 12/29/2022 at 6:46 PM, Kvellen said:

    Hey @Noqn , hope you are enjoying some time off for the holidays if you got it!

    Thanks 😄 had a boatload of vacation days saved up!

    On 12/29/2022 at 6:46 PM, Kvellen said:

    Would it be possible for you to make Apotheosis generate a conversation.manfest entry for new conversations on their creation?

    Oh wow thanks, I wasn't even aware of conversation manifests, I'll make sure they are generated.

    On 12/30/2022 at 11:58 AM, Grape_You_In_The_Mouth said:

    Where is the short list of features?  I'm confused if it can add new recipes, items, etc. and couldn't easily find a way to do it on the program. 

    All you've written re: documentation is invaluable feedback, many thanks!

    I'm thinking about moving the documentation to the gitlab project's wiki page, then adding a "Help" or ? button to the application's header bar which will open that web page. Sounds good?

    On 12/31/2022 at 3:43 PM, Grape_You_In_The_Mouth said:

    Seems important to be able to determine which stringtable ranges are newly assigned

    Good point, how about displaying the mod's stringtable range in the Manifest-editing dialog?

    On 12/31/2022 at 3:43 PM, Grape_You_In_The_Mouth said:

    I was able to create a null ItemMod debugname somehow.  Thought I typed in the name but regardless, having no debugname was apparently allowed in the editor but once I tried to reopen the editor and load my mod, it rejected it for the empty debugname.  All the error checks on loading mods are very impressive!

    Thanks, I'm super happy how the error messages turned out 😄 I'll check ot the null debugname bug tho

    • Like 1

    Apotheosis - Mod Editor for Deadfire

    in Pillars of Eternity II: Deadfire: Modding (Spoiler Warning!)

    Posted

    Quote

    Just for curiosity, could you explain a bit how you do the String Table Query search? I'm looking at the code but I'm struggling a lot through all the abstractions of dics. Even so, if I understand it correctly, isn't the search ultimately done in Matches()/Contains() by parsing through all the text entries in all the files and searching for the query? So a "sequential" search.

    Yeah pretty much. All StringTableEntry text are stored when the mods are loaded, so here I'm just enumerating through the collections and doing standard string comparisons. If its particularily fast, it's thanks to .NET string comparisons being well optimized 😅

    Quote

    I'm looking at the code but I'm struggling a lot through all the abstractions of dics

    mmm, it's a bit awkward how the StringTableEntries are stored. You basically got three levels of nested Dictionaries:

    1. First you got a Dictionary with string keys (defining the language) and nested Dictionary values.
    2. These nested Dictionaries* has either GameData categories (e.g. Abilities, Items) or a path (e.g. "conversations\00_prototype\00_cv_drummer") as keys, and again nested Dictionaries as values.
    3. Lastly, these Dictionaries have int keys (StringTableEntry IDs) and StringTableEntry values.

    (*The second layer is a actually a class that wraps dictionaries and exposes some helper methods. Maybe this could be replaced in favor of just using extension methods?)

    Apotheosis - Mod Editor for Deadfire

    in Pillars of Eternity II: Deadfire: Modding (Spoiler Warning!)

    Posted · Edited by Noqn

    Added a String Table Query to the sidebar!

    It will check for matching entries in the standard, Conversation and Quest StringTables:

    AHI0VFO.png

    Clicking a row under GameData StringTables will open that StringTable in a new tab.
    Clicking a row under Conversation/Quest StringTables will open that convo/quest in a new tab. (You can then go to the StringTable view in that tab and find the specific entry from there.)

    • Like 3

    Apotheosis - Mod Editor for Deadfire

    in Pillars of Eternity II: Deadfire: Modding (Spoiler Warning!)

    Posted · Edited by Noqn

    @RilleL Thanks for reporting. Yeah, this is the GUI library's doing... The "number editor" popup belongs to a particularily ancient part of the library and has quirks. The widget itself is basically a glorified text entry.

    To explain the 000000's, It's default behavior is to fill itself with with trailing 0's decimals. I've however disabled the decimals when editing an integer, and made it so that the decimals in a float value will initially be trimmed away. But once you press the +/- buttons, the widget will again fill the entry with trailing 0's decimals.

    It also formats the string independently of .NET locale like you guessed. I've published a new release which *should* fix the parsing of the string that is returned from the popup on all locales. Can you verify that the latest version is working?

    ______

    Also, Thanks @Kvellen for finding some quite severe regressions and bugs:

    2022-12-13

    - TalkNode Speaker and Listener options are now updated when Character Mappings are edited
    - Fix float values being parsed incorrectly in GameData editor
    - Stop incorrectly throwing MismatchFromNodeID exception when loading Quests
    - Fix recusion causing stack overflow when editing Quest string tables.

    • Like 1

    Apotheosis - Mod Editor for Deadfire

    in Pillars of Eternity II: Deadfire: Modding (Spoiler Warning!)

    Posted

    I'm actually doing this for the .gamedatabundles that are compiled to apotheosis_exported to improve load times 🙂 all booleans/numbers/Guids/enums with default values are skipped.

    I've vaguely played with the idea of letting users trim the output (and also disable JSON formating) before, so it's cool you brought it up. In terms of what's theoretically safe to skip:

    1. Edits to pre-existing GameDataComponents' properties -> has to be included to register the change.
    2. New GameDataComponents' properties -> could probably be skipped.
    3. Struct properties -> can safely be skipped.

    One major concern I have is that it would be significantly harder to debug or manually fix the mod if a bunch of properties are hidden, so in terms of readability it might actually do more harm than good.
    Also, it might give users the impression that something has gone wrong if not everything is written. If I were to add a feature like this, it would have to be opt-in.

    In terms of size, while it depends on the data type, I suspect the difference would be negligible. Some of the really large data types like ProgressionTables actually has a smaller portion of values that are safe to default. I could see the case for this feature if you were to auto-generate a bunch of GameData with the User Script feature.

    At the moment I would be against it, but it's in the "definitely worth considering" category. I've added an issue to GitLab for the future.

    Apotheosis - Mod Editor for Deadfire

    in Pillars of Eternity II: Deadfire: Modding (Spoiler Warning!)

    Posted · Edited by Noqn

    • 2022-12-10
    • Popups will now "gray out" their parent dialogs and not just the main window.
    • Improvements to Bundle Path selector:
      • Existing files are now hidden when selecting where to create a new Conversation or Quest.
      • Add labels to New File/Folder popups indicating which you clicked, e.g. "New .conversationbundle"
      • New File button in the headerbar is moved to the left of the New Folder button for consistency with icons in the rows.
      • Clicking the empty area to the left of the New File icon in the rows will no longer trigger the New File popup.
    • Exception handling when a Conversation or Quest couldn't be loaded:
      • If it's a "fixable" issue, a confirmation dialog will be displayed with the option to either apply the fix or close the tab.
      • If it's not "fixable", a message dialog with the exception message will be displayed and the tab will close.
      • Excplicit messages have been created for most FlowChart errors.
         
    • Like 2

    Apotheosis - Mod Editor for Deadfire

    in Pillars of Eternity II: Deadfire: Modding (Spoiler Warning!)

    Posted · Edited by Noqn

     Ok, here we go again:

    From now on, if an exception is thrown when a conversation or quest is loaded, and the issue is easily fixed (in this case setting some links' PointsToGhost to true), the user will get the option to either close the tab or let Apotheosis apply the fix:

    9qSVwG6.png

    If there's no straightforward fix or something fundamental is wrong (like a missing root node), the tab will close and a simple message will be displayed:

    gNwsgVb.png

×
×
  • Create New...