1st off, great stuff all good points.
I agree about 'basement' damage, 1 of my character's has been using a magical scythe for the longest time and seem to always nudge out the competition. In terms of 'bonus damage when you roll X', I always prefer that X=the lowest numbers rather than the highest numbers for the exact reasons you discussed. Weirdly enough, my scythe fits into both categories discussed here. It's great because about have multiple dice, but that bonus +1 when i roll a 4 would have been a lot more valuable if it wall on a roll of 1. I remember an early weapon called 'dogslicer' or something that modified 1's into 3's, needless to say, that was a really beneficial ability. The only problem about these abilities is that they make calculating the average damage of a roll slightly more complicated and annoying.
I also agree about the riskiness of poison damage, seems too often my poison weapon had a lock on it 50% of the time.
Good point about characters who recycle weapons, that also is a factor that should be on the list. My current party has great spell recycle right now, but not as good weapon recycle. Although my barbarian holds enough weapons (with little investment in weapon card feats) that I rarely mind just discarding for full damage as I hate getting stuck with too many weapons in my hand.
I remember calculating similar weapon choices when I used to play d&d 3.5, but, honestly, its a lot more complicated calculating it in this game because of all the factors such as, discard, reveal, recharge. Also the cost of a weapon was a lot more accurate of a weapon's value in d&d than the difficulty modifiers in pathfinder card game.
Maybe after we get enough input from a lot of users, I can streamline these tips/tricks into a guide for beginners or other players looking it up.
And feel free to add your 'nerdy' input---we are waaay beyond that threshold here: we are using a mathematical approach to discussing fantasy weapons in a video game based on a solo playing board game, which is based on, arguably, the most famous nerd game (d&d/pathfinder). Don't worry we can chug beers, watch football and talk about women after we get through this to balance the scales